OneNAND: Check first or second pages for bad block information

Kyungmin Park kyungmin.park at samsung.com
Mon Jan 22 02:33:16 EST 2007


Hi,

I'm not sure we have to check 2nd page. Yes, Spec. says we will check 1st and 2nd ones.

It increase the boot time even though it's smaller one than others.

Let me think, when we check 2nd page case.
In initial bad, no need to check 2nd page.
In runtime bad, it is only happend when first page write failed. But during write it has non-0xFF value. so next time it will be detected as invalid.

How do you think about it?

Thank you,
Kyungmin Park


------- Original Message -------
Sender : Adrian Hunter<ext-adrian.hunter at nokia.com> 
Date   : Jan 19, 2007 23:37
Title  : [PATCH] [MTD] OneNAND: Check first or second pages for bad block
 information


OneNAND records bad block information in the out-of-band area of
either the first or second page of a block.  Due to a logic error,
only the first page was being checked.

Signed-off-by: Adrian Hunter <ext-adrian.hunter at nokia.com>
---
 drivers/mtd/onenand/onenand_bbt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/onenand/onenand_bbt.c b/drivers/mtd/onenand/onenand_bbt.c
index 90db8f5..aa46b7f 100644
--- a/drivers/mtd/onenand/onenand_bbt.c
+++ b/drivers/mtd/onenand/onenand_bbt.c
@@ -68,7 +68,7 @@ static int create_bbt(struct mtd_info *m
 
 	printk(KERN_INFO "Scanning device for bad blocks\n");
 
-	len = 1;
+	len = 2;
 
 	/* We need only read few bytes from the OOB area */
 	scanlen = ooblen = 0;
-- 
1.4.3





More information about the linux-mtd mailing list