[PATCH 4/4] NOMMU: Make it possible for RomFS to use MTD devices directly
David Howells
dhowells at redhat.com
Thu Feb 22 06:43:00 EST 2007
Andrew Morton <akpm at linux-foundation.org> wrote:
> > + brelse(bh);
>
> A little fyi: brelse() is rather old-fashioned, and has a usually unneeded
> test for non-null bh in it. In situations where we know that the pointer is
> valid, let's please use put_bh().
That's what was in the old romfs. I can make the change, though.
Hmmm... brelse() isn't quite equivalent to put_bh(), but the difference seems
just to be the message you get if you over-release a buffer head - and the
resulting refcount on the BH if that happens.
> Anyway, I'll assume that dwmw2 will be handling this patch series.
I assume so.
David
More information about the linux-mtd
mailing list