PATCH: calculate s3c2410 NAND timing values more accurately

Matthieu CASTET matthieu.castet at parrot.fr
Tue Feb 13 05:46:40 EST 2007


Hi,

Matt Reimer <mattjreimer <at> gmail.com> writes:

> 
> Calculate NAND timing values more accurately on S3C2410, 2412, and
> 2440, whose registers differ slightly:
> 
> Enforce the TACLS max value as 3 on 2440 but 7 on 2410/2412.
> 
> Also, make it possible to specify a value of 0 on 2412/2440.
> 

If you remove the "if (result < 1) result = 1;" check in s3c_nand_calc_rate, I
believe you should check for twrph0 or twrph1 equal 0 in s3c2410_nand_inithw (ie
if (tacls < 0 || twrph0 <= 0 || twrph1 <= 0) { return error).

Matthieu





More information about the linux-mtd mailing list