[PATCH v2 4/4] Freescale enhanced Local Bus Controller FCM NAND support.

Arnd Bergmann arnd at arndb.de
Fri Dec 14 16:40:48 EST 2007

On Friday 14 December 2007, Anton Vorontsov wrote:
> > >Maybe this desires its own header?
> > 
> > It can be factored out if anything else ever uses it.
> It's just confusing to parse lbc-specific and nand-specific code
> placed in the same file.

In that case, you could argue for splitting the implementation into
two C files. I don't see any reason to move stuff into a header
when it's not an interface between two parts of the code, but
only describes a hardware interface used by a single driver.

	Arnd <><

More information about the linux-mtd mailing list