[PATCH 09/30] mtd: Don't cast kmalloc() return value in drivers/mtd/maps/pmcmsp-flash.c
jesper.juhl at gmail.com
Sat Aug 25 20:28:42 EDT 2007
On 26/08/07, Robert P. J. Day <rpjday at mindspring.com> wrote:
> On Sun, 26 Aug 2007, Jesper Juhl wrote:
> > On 24/08/07, Robert P. J. Day <rpjday at mindspring.com> wrote:
> > > actually, i would think kcalloc would be more appropriate here, no?
> > >
> > Why?
> > msp_parts[i] = kzalloc(pcnt * sizeof(struct mtd_partition), GFP_KERNEL);
> > seems better to me than
> > msp_parts[i] = kcalloc(1, pcnt * sizeof(struct mtd_partition), GFP_KERNEL);
> i was thinking more along the lines of
> msp_parts[i] = kcalloc(pcnt, sizeof(struct mtd_partition), GFP_KERNEL);
> which was kind of the obvious implication, no?
> unless there's a
> reason kcalloc() wouldn't work here, this is pretty much what
> kcalloc() was designed for.
When Denys brought up the zeroing thing and mentioned kzalloc() I did
consider kcalloc() instead, but kzalloc() makes this allocation nicely
look like the preceding ones visually and I couldn't convince myself
that kcalloc() would give us any real benefit here.
What exactely would using kcalloc() over kzalloc() here buy us?
Jesper Juhl <jesper.juhl at gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
More information about the linux-mtd