[PATCH] UBI: Don't use signed int as array index before testing if it is negative

Artem Bityutskiy dedekind at infradead.org
Sat Aug 4 05:16:22 EDT 2007

On Sat, 2007-08-04 at 01:25 +0200, Jesper Juhl wrote:
> Hi,
> I can't find anything guaranteeing that 'ubi_num' cannot be <0 in 
> drivers/mtd/ubi/kapi.c::ubi_open_volume(), and in fact the code 
> even tests for that and errors out if so. Unfortunately the test 
> for "ubi_num < 0" happens after we've already used 'ubi_num' as 
> an array index - bad thing to do if it is negative.
> This patch moves the test earlier in the function and then moves 
> the indexing using that variable after the check. A bit safer :-) 
> Signed-off-by: Jesper Juhl <jesper.juhl at gmail.com>

Thanks for the catch, committed to UBI git tree.

Best regards,
Artem Bityutskiy (Битюцкий Артём)

More information about the linux-mtd mailing list