[PATCH] [MTD] [NAND]: nand_default_mark_blockbad() doesn't work when flash-based bbt not enabled

Vitaly Wool vwool at ru.mvista.com
Thu Oct 26 04:55:17 EDT 2006


Ricard Wanderlof wrote:
> On Tue, 24 Oct 2006, Vitaly Wool wrote:
>
>   
>>> Hm. That seems wrong to me. If we don't want to read or write the main
>>> area, we should set ops.len to zero. And if that doesn't work, it should
>>> probably be fixed.
>>>
>>> I'd rather see a patch which fixes that.
>>>
>>>
>>>       
>> We discussed that w/ tglx some time ago and we couldn't find a 5 minute
>> solution :)
>>     
>
> Was there a discussion on the mtd list? I scanned the archives back to 
> April and couldn't find anything.
>   
No, we did chat in #mtd channel.

Anyway, here's what I think of that. It looks like the idea was to use 
ops.len in order to read more than ooblen bytes, i. e. more than one OOB 
area basically, and preserve ooblen to signal how many bytes there is in 
one oob. However, that seems misleading/redundant since you can always 
figure out how many bytes there are in oob, so it looks like making that 
all work w/ ooblen is better.

Does that make sense?
I'm going to work on that as soon as load permits...

Vitaly




More information about the linux-mtd mailing list