[PATCH/RFC] remove len/ooblen confusion in MTD/NAND code

Vitaly Wool vwool at ru.mvista.com
Thu Nov 2 02:02:25 EST 2006


Hi Artem,

Artem Bityutskiy wrote:
> Hello Vitaly,
>
> the patch looks logical for me, please find my comments below.
>
> 1. You did not change comments above the 'struct mtd_oob_ops' structure
> declaration.
>   
Oh right, thanks. I'll come up shortly with a new one.
> On Mon, 2006-10-30 at 14:51 +0300, Vitaly Wool wrote:
>   
>>  		if (devops.datbuf)
>>  			devops.datbuf += devops.retlen;
>>  		if (devops.oobbuf)
>> -			devops.oobbuf += devops.ooblen;
>> +			devops.oobbuf += subdev->oobsize;
>>     
>
> Is this is an independent bug-fix?
>
>   
No. The point here is that devops.ooblen is no more the OOB size, so we 
have to obtain OOB size from somewhere else. I. e. for the old version 
this would have been an equivalent change.

Vitaly





More information about the linux-mtd mailing list