[PATCH,RFC] [MTD] replace MTD_NORFLASH with MTD_GENERIC_TYPE

Nicolas Pitre nico at cam.org
Tue May 30 12:32:58 EDT 2006


On Tue, 30 May 2006, Jörn Engel wrote:

> On Tue, 30 May 2006 20:01:33 +0400, Artem B. Bityutskiy wrote:
> > 
> > I'm absolutely against this trend. You'll soon make all flashes of
> > MTD_GENERIC_TYPE, then you'll remove mtd->type altogether.
> > 
> > We debated about this a lot. And you still didn't explain why I have no
> > right to know the  flash type.
> > 
> > Please, introduce your capabilities stuff, but please, stop removing
> > mtd->type implicitly or explicitly. 
> > 
> > AFAICS, what you're doing now is you're introducing reasonable
> > "capabilities" stuff, and slowly removing the mtd->type stuff. Please,
> > do one thing.
> 
> Artem, for some reason I can't seem to either understand you or change
> your mind.  You firmly want to keep mtd->type for a reason I cannot
> understand.  And I firmly believe that mtd->type is useless at best
> and outright harmful at worst.  Most likely one of us is wrong, but
> since we can't reach common grounds, I stopped arguing with you.  It
> is pointless, sadly.
> 
> If it is me, who is wrong, I hope dwmw2 will show just that.  If my
> plans are sound, I hope he will agree and continue to merge patches.

I'm firmly with you and so far I agree 100% with your effort.  The 
cleanups you're providing are much appreciated.

However Artem might have a point.  You probably should leave mtd->type 
alone, at least for now.  It is good to not depend on it anymore but it 
probably still has its informative value, just like name string attached 
to MTD partitions.  If it should go then it should be removed at the 
very end when no one uses it anymore.


Nicolas


More information about the linux-mtd mailing list