[PATCH,RFC] [MTD] replace MTD_NORFLASH with MTD_GENERIC_TYPE

David Woodhouse dwmw2 at infradead.org
Tue May 30 11:55:02 EDT 2006


On Tue, 2006-05-30 at 17:50 +0200, Jörn Engel wrote:
> Until recently, we had four different variants of jffs2 wbuf code,
> depending on the flash type.  I fail to see the difference between
> those four and have already merged two of them.  Unless I am missing
> something important, the other three can also be combined into one.
> 
> But doing so would result in something like
>         if ((mtd->type == MTD_NAND) || (mtd->type == MTD_SIBLEY) ||
>                         (mtd->type == MTD_ECCNOR) ||
>                         (mtd->type == MTD_DATAFLASH))

That's why we _also_ have the flags, and why we abstract that still
further in application-specific code, like jffs2_can_mark_obsolete()

But you seem to want to kill _both_ the type _and_ the flag -- you say
that you want the MTD_KF_NOR_WBUF_FLASH flag to go away. So explain --
what do you want to do instead?

-- 
dwmw2





More information about the linux-mtd mailing list