[PATCH] for passing JFFS2 options at mount time

[Jörn Engel]

On Tue, 23 May 2006 11:44:18 +0200, Ronny L Nilsson wrote:
> 
> > > -#ifdef CONFIG_JFFS2_PROC
> > >
> > >  #define JFFS2_STAT_BUF_SIZE 16000
> >
> > This makes sense, but should go in a seperate patch.
> >
> > > @@ -330,18 +326,37 @@ char *jffs2_get_compression_mode_name(vo
> >
> > #elif
> >
> 
> Jörn, I'm not sure I understand what you mean here but perhaps 
> something like in this patch? I've left pretty much of the previous  
> #ifdef CONFIG_JFFS2_PROC  intact now. Since there was no easy way for 
> the user to configure this option I made a change in the parent Kconfig 
> as well though, to let him choose whether runtime options shall be 
> built. Did I get you right?

Ronny, I'm not sure I understand what you mean here but perhaps...
...perhaps you didn't get me right.

What I said was that the removal of #ifdef CONFIG_JFFS2_PROC had
nothing to do with the rest of the patch.  Patches should do one thing
and do it well.  So all you should do is send two patches, one for the
#ifdef removal and the other for your mount option.

And dwmw2 is right, the mount option would make more sense as a
superblock element.

Jörn

-- 
Don't worry about people stealing your ideas. If your ideas are any good,
you'll have to ram them down people's throats.
-- Howard Aiken quoted by Ken Iverson quoted by Jim Horning quoted by
   Raph Levien, 1979