[PATCH] for passing JFFS2 options at mount time

[Ronny L Nilsson]

Hi
Here's an update for my JFFS2 mount option patch. It allow users to 
control runtime options on a per mounted fs basis.
	mount -t jffs2 mtd1 /flash -o compressor=none
	mount -t jffs2 mtd1 /flash -o compressor=priority
I'm sorry for the long reply delay Jörn! Thanks for your comments.



> > -#ifdef CONFIG_JFFS2_PROC
> >
> >  #define JFFS2_STAT_BUF_SIZE 16000
>
> This makes sense, but should go in a seperate patch.
>
> > @@ -330,18 +326,37 @@ char *jffs2_get_compression_mode_name(vo
>
> #elif
>

Jörn, I'm not sure I understand what you mean here but perhaps 
something like in this patch? I've left pretty much of the previous  
#ifdef CONFIG_JFFS2_PROC  intact now. Since there was no easy way for 
the user to configure this option I made a change in the parent Kconfig 
as well though, to let him choose whether runtime options shall be 
built. Did I get you right?





> > +	/* Parse mount options */
> > +	c->compression_mode = JFFS2_COMPR_MODE_UNKNOWN;
> > +	parse_options(c, data);
> > +
> >  	if ((ret = jffs2_do_mount_fs(c)))
> >  		goto out_inohash;
>
> Why do you need JFFS2_COMPR_MODE_UNKNOWN?  Wouldn't it make more
> sense to do exactly the same thing as now - have a compile time
> default - and merely allow users to add a mount option to change the
> default?

Indeed, you're right... I've changed it now.


Regards
/Ronny



-------------- next part --------------
A non-text attachment was scrubbed...
Name: jffs2-mountoptions-v2.diff
Type: text/x-diff
Size: 10490 bytes
Desc: not available
Url : http://lists.infradead.org/pipermail/linux-mtd/attachments/20060523/9bbd80b0/attachment.bin