[PATCH] MTD: mtdconcat NAND/Sibley support (revised)

[Jörn Engel]

On Fri, 5 May 2006 16:08:21 +0400, Belyakov, Alexander wrote:
> 
> +concat_writev_ecc (struct mtd_info *mtd, const struct kvec *vecs,
> unsigned long count, 

Your mailer is eating this patch.  Can you either fix your mailer and
resend, resend with a different mailer or resend as attachment?
Inline patch is preferred.

Also, the lines were >80 columns before your mailer mangled them.

> +	return (concat_writev_ecc(mtd, vecs, count, to, retlen, NULL,
> NULL));

Remove redundant brackets.

> +concat_writev_ecc (struct mtd_info *mtd, const struct kvec *vecs,
                    ^
Remove space

> unsigned long count, 
> +		loff_t to, size_t * retlen, u_char *eccbuf, struct
                                   ^
and here.

> +	/* Calculate total length of data */
> +	for (i = 0; i < count; i++)
> +		total_len += vecs[i].iov_len;
> +		
   ^^^^^^^^^^^^^
Remove whitespace damage

> +		DEBUG (MTD_DEBUG_LEVEL0, "concat_writev_ecc(): Attempted
                     ^
> +    
   ^^^^

etc.

For some things, I'd like to apply the patch and use tkdiff to see
more than three lines of context.  So this is not a final review, but
just a "resend with sane mailer" plus a few cosmetics, while we're at
it.

Jörn

-- 
Beware of bugs in the above code; I have only proved it correct, but
not tried it.
-- Donald Knuth