[PATCH,RFC] ts72xx NAND driver

[Jörn Engel]

On Thu, 2 March 2006 14:12:03 +0100, Lennert Buytenhek wrote:
> 
> Any feedback appreciated..

Just some minor (irrelevant?) stuff.

> +extern int parse_cmdline_partitions(struct mtd_info *master,
> +		struct mtd_partition **pparts, const char *mtd_id);

Adrian Bunk would send a patch against these lines within a few weeks.
His reasoning is that .c files should include headers instead of
adding function declarations on their own.

> +	if (nand_scan (ts7250_mtd, 1)) {
> +		kfree (ts7250_mtd);
                     ^
Non-compliant to kernel coding style.

> +	del_mtd_device (ts7250_mtd);

Jörn

-- 
To my face you have the audacity to advise me to become a thief - the worst
kind of thief that is conceivable, a thief of spiritual things, a thief of
ideas! It is insufferable, intolerable!
-- M. Binet in Scarabouche