[PATCH]Fixes of performance and stability issues in CFI driver.

David Woodhouse dwmw2 at infradead.org
Tue Jun 27 09:55:43 EDT 2006


On Tue, 2006-06-27 at 13:40 +0100, Alexey Korolev wrote:
> 
> static inline void cfi_udelay(int us)
> {
>         if (us >= 1000) {
>                 msleep((us+999)/1000);
>         } else {
>                 udelay(us);
>                 cond_resched();
>         }
> }
> According to spec Sibley buffer write time is 2048us. It is greater
> than 1000us. 
> So we call msleep which has resolution 10000 us.  

I don't like your 'timer_resolution' fix. Why not just fix cfi_udelay()
to use udelay() or mdelay() or msleep() in order of increasing delay?

-- 
dwmw2





More information about the linux-mtd mailing list