Current mtd tree is broken

Artem B. Bityutskiy dedekind at infradead.org
Thu Jun 22 02:52:53 EDT 2006


On Wed, 2006-06-21 at 17:35 -0500, Josh Boyer wrote:
> As panto pointed out on IRC today, the current MTD git tree is
> completely broken for quite a few chip types.  Anything older than
> Intel Sibley or P30 is broken since writesize is not set to something
> other than 0 in the other cases.  This causes a BUG to trigger in
> add_mtd_device because someone decided writesize == 0 was not a sane
> thing.

How about this?

writesize is a new feature and many drivers may not initialize it. It
might be harmless, depending on the usage of the driver. So don't be
that difficult and issue warning instead of getting into panic.

Signed-off-by: Artem B. Bityutskiy <dedekind at infradead.org>

-- 
Best Regards,
Artem B. Bityutskiy,
St.-Petersburg, Russia.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: writesize-warn.diff
Type: text/x-patch
Size: 353 bytes
Desc: not available
Url : http://lists.infradead.org/pipermail/linux-mtd/attachments/20060622/fdcbb84b/attachment.bin 


More information about the linux-mtd mailing list