[PATCH] CM-x2xx NAND flash support
tglx at linutronix.de
Tue Jul 11 04:23:53 EDT 2006
On Tue, 2006-07-11 at 10:46 +0200, Mike Rapoport wrote:
> >>+ unsigned int nandaddr = (unsigned int)this->IO_ADDR_W;
> >what the hell is this type cast for ?
> > void __iomem *nandaddr =
> you can't do |= and &= with void __iomem*
Err, why not ?
> >Can you please combine both drivers into one and make it a platform
> >device. There is no need to keep lots of duplicate functionality around.
> I'm dropping cm-x255 support (management decision) so there's only one
> platform that can use this driver. What's the point then?
Sorry man, you submitted _two_ drivers in the first place and I did the
review on those. I'm not good at witchcrafting the decisions of your
More information about the linux-mtd