[2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

Jarkko Lavinen jarkko.lavinen at nokia.com
Fri Dec 1 08:41:57 EST 2006


Our bootloader once used mtdpart_setup() for passing mtd partitions to 
kernel. We do not do that any more and instead use the kernel command line 
for passing the information.

Jarkko Lavinen

On Thu, Nov 30, 2006 at 10:45:56AM -0800, ext Andy Isaacson wrote:
> On Sat, Nov 25, 2006 at 08:15:41PM +0100, Adrian Bunk wrote:
> > This patch makes the needlessly global mtdpart_setup() static.
> > 
> > @@ -346,7 +346,7 @@
> >   *
> >   * This function needs to be visible for bootloaders.
> >   */
> > -int mtdpart_setup(char *s)
> > +static int mtdpart_setup(char *s)
> >  {
> >  	cmdline = s;
> >  	return 1;
> 
> Jarkko,
> 
> You're recorded as submitting the original patch to make this
> non-static:
> http://linux.bkbits.net:8080/linux-2.6/diffs/drivers/mtd/cmdlinepart.c@1.11?nav=index.html|src/|src/drivers|src/drivers/mtd|hist/drivers/mtd/cmdlinepart.c
> 
> Is this change correct?
> 
> If so, it should also delete the "needs to be visible" comment.
> 
> -andy




More information about the linux-mtd mailing list