[PATCH] Fix IXP4xx MTD driver no cast warning
joern at wohnheim.fh-wedel.de
Thu Sep 29 19:02:23 EDT 2005
On Thu, 29 September 2005 13:00:18 -0700, Linus Torvalds wrote:
> On Thu, 29 Sep 2005, Deepak Saxena wrote:
> > drivers/mtd/maps/ixp4xx.c: In function 'ixp4xx_flash_probe':
> > drivers/mtd/maps/ixp4xx.c:199: warning: assignment makes integer from
> > pointer without a cast
> Please don't. The warning is entirely warranted, as far as I can tell.
> Shutting up warnings just because they are warnings is bad practice.
> Either fix them, or leave them be.
> If you do an "ioremap()", then the result is a "(void __iomem *)". If you
> assign it to something that is "unsigned long", you _should_ get a
Code is correct, as far as this specific mapping driver is concerned.
But it would make some sense to convert one of the map_priv_ in
struct map_info to (void __iomem *).
It does not matter how slowly you go, so long as you do not stop.
More information about the linux-mtd