[PATCH] jffs2 whitespace

Peter Grayson pgrayson at realmsys.com
Mon Sep 26 13:17:53 EDT 2005


On Mon, 2005-09-26 at 13:01 +0200, Jörn Engel wrote:
> On Mon, 26 September 2005 13:46:04 +0400, Artem B. Bityutskiy wrote:
> > Jörn Engel wrote:
> > >Because we want things like ebh, summary, xattr, etc.?  If we accept
> > >this patch, it makes life a bit worse for people who write the stuff
> > >we want.  It may be the straw that makes them go away and never come
> > >back.

I agree that other patches are more important than code formatting.
However, we may also enable more people to contribute to jffs2 if the
code is as readable/understandable as possible. I want to help make a
small, but tangible step in that direction.

> Imo, the costs outweigh the benefit.  [ Which doesn't mean that I
> question the benefit.  It's just not big enough. ]

Since there appears to be at least some benefit, maybe we can do this in
easy to digest pieces. I have made another patch just against the files
concerning compression in jffs2. These files had a lot of problems and I
do not believe they conflict with any of the main outstanding patches
(ebh, xattr, centsum).

Thanks to Jörn and Artem for their feedback; it is much appreciated.

Pete
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jffs2-whitespace-compr.patch
Type: text/x-patch
Size: 47636 bytes
Desc: not available
Url : http://lists.infradead.org/pipermail/linux-mtd/attachments/20050926/ff75f6f7/attachment.bin 


More information about the linux-mtd mailing list