zhao_fusheng at hotmail.com
Thu Sep 22 22:33:02 EDT 2005
>From: Ferenc Havasi <havasi at inf.u-szeged.hu>
>To: Jörn Engel <joern at wohnheim.fh-wedel.de>
>CC: "Artem B. Bityutskiy" <dedekind at infradead.org>, zhao forrest
<zhao_fusheng at hotmail.com>, linux-mtd at lists.infradead.org
>Subject: Re: 1:1 mapping
>Date: Fri, 23 Sep 2005 01:48:31 +0200
>Jörn Engel wrote:
> >On Thu, 22 September 2005 17:54:58 +0400, Artem B. Bityutskiy wrote:
> >>On Thu, 2005-09-22 at 15:48 +0200, Jörn Engel wrote:
> >>>Can you explain "when JFFS2 has detected that the image is an old
> >>>image" in C?
> >>Well, we may even do better. Scan FS. If we meet any node which crosses
> >>the eraseblock boundary - bye bye. That must be easy to implement as
> >>node headers contain the total node length.
> >Sounds fine. Yes, that appears to be the best solution.
>Yes, that is the same I wrote in my letter. As Artem asked me to
>implement it I wrote a patch, you can find it at
>I have not tested it yet (it will be task of tomorrow) I would just to
>show what is in my mind.
Your patch may have problem.
In fact this "reject to mount when cross-boundary" has been in my
patch, it's quite simple. This code segment is extracted from my patch:
@@ -570,10 +584,8 @@ scan_more:
/* Eep. Node goes over the end of the erase block. */
printk(KERN_WARNING "Node at 0x%08x with length 0x%08x would
run over the end of the erase block\n",
- printk(KERN_WARNING "Perhaps the file system was created
with the wrong erase size?\n");
- ofs += 4;
+ printk(KERN_NOTICE "Perhaps the file system
was created with the wrong erase size? Reject to mount.\n");
+ return -EINVAL;
More information about the linux-mtd