[PATCH] Adding eraseblock header support(revised version)

[Artem B. Bityutskiy]

zhao forrest wrote:
> Your comments for the revised patch are welcome :)

+               if ((!jeb->has_eraseblock_header && jeb->free_size !=
c->sector_size - c->cleanmarker_size) ||
+                   (jeb->has_eraseblock_header &&
c->eraseblock_header_size && jeb->free_size != c->sector_size -
jeb->first_node->__totlen) ||
+                   (jeb->has_eraseblock_header &&
!c->eraseblock_header_size && jeb->free_size != c->sector_size))
+               {

1. I would not use so looong lines. There is a 80 chars restriction. In
JFFS2 it is OK to use long lines for prints.

2. jeb->has_eraseblock_header - so looong name ... Why not to use
jeb->has_ebh ?


-- 
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.