1:1 mapping

[Jörn Engel]

On Thu, 22 September 2005 08:05:10 -0500, Josh Boyer wrote:
> On Thu, 2005-09-22 at 14:20 +0200, Jörn Engel wrote:
> > 
> > Or we tell users very clearly about the problem.  In a way they can't
> > ignore.  Proposed patch below.
> 
> Erm... I hope that was a bit sarcastic.  Actually putting something like
> that into the kernel would look a bit ridiculous.

Apart from a missing dependency on CONFIG_MTD, no.  With the BIG FAT
WARNING mail sent to the list, everyone tracking CVS should know about
the problem.  But the remaining people who upgrade via -linus might
still have a problem.  This way, they also get forced to notice.

If you have a better idea, please speak up.  This beats an
incompatible option by far, imo.  We could also do something like
this:

int jffs2_blocks_use_vmalloc(struct jffs2_sb_info *c)
{
	int ret = ((c->flash_size / c->sector_size) * sizeof (struct jffs2_eraseblock)) > (128 * 1024);
	if (unlikely(ret)) {
		printk(KERN_ERR "Please read up on the virtual mapping stuff");
		BUG();
	}
	return ret;
}

Then all people who depend on Ferenc's virtual mapping patch to work
will see a warning message.  Others don't notice.  People may remove
the BUG and printk if they know what they're doing.

Then after a couple of kernel versions, we'll turn it into a one-time
warning and a bit later completely remove it.

Jörn

PS: I really don't care about looking ridiculous here.  As long as it
solved people's problems, that's just fine.

-- 
Linux is more the core point of a concept that surrounds "open source"
which, in turn, is based on a false concept. This concept is that
people actually want to look at source code.
-- Rob Enderle