mtd_blkdevs.c missing flush_dcache_page()

Atsushi Nemoto anemo at mba.ocn.ne.jp
Wed Oct 19 06:26:29 EDT 2005


>>>>> On Mon, 17 Oct 2005 21:27:39 -0700, Matthew Reimer <mreimer at vpop.net> said:
mreimer> I came across this post in which RMK says mtd_blkdevs.c is
mreimer> missing a call to flush_dcache_page(), patch included:

mreimer> http://lists.arm.linux.org.uk/pipermail/linux-arm-kernel/2005-May/029023.html

mreimer> I suppose not calling flush_dcache_page() could result in
mreimer> file corruption.

mreimer> Should this patch be applied?

Yes.  Without this patch, I saw file corruption on following
conditions:

* CPU have dcache aliasing
* use ext2 (etc.  not jffs2 neither cramfs) on /dev/mtdblock
* mmap and read a file in the filesystem

I tested this patch on MIPS and it works fine.

---
Atsushi Nemoto




More information about the linux-mtd mailing list