[PATCH] [Trivial] Make physmap messages more user friendly

Deepak Saxena dsaxena at plexity.net
Thu Oct 13 21:07:26 EDT 2005

Can I commit the following to CVS? It makes the message a bit more
readalbe (and obvious that it is in hex) and tells the user if 
the probe failed.

Signed-off-by: Deepak Saxena <dsaxena at plexity.net>

diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -50,11 +50,12 @@ static int __init init_physmap(void)
 	static const char *rom_probe_types[] = { "cfi_probe", "jedec_probe", "map_rom", NULL };
 	const char **type;
-       	printk(KERN_NOTICE "physmap flash device: %lx at %lx\n", physmap_map.size, physmap_map.phys);
+       	printk(KERN_NOTICE "MTD physmap flash device: %#010lx @ %#010lx\n", 
+			physmap_map.size, physmap_map.phys);
 	physmap_map.virt = ioremap(physmap_map.phys, physmap_map.size);
 	if (!physmap_map.virt) {
-		printk("Failed to ioremap\n");
+		printk("MTD physmap: Failed to ioremap\n");
 		return -EIO;
@@ -90,6 +91,8 @@ static int __init init_physmap(void)
 		return 0;
+	} else {
+		printk("MTD physmap: failed to probe flash\n");

Deepak Saxena - dsaxena at plexity.net - http://www.plexity.net

Even a stopped clock gives the right time twice a day.

More information about the linux-mtd mailing list