[PATCH 1/2] --cvs-exclude for mkfs.jffs2

Josh Boyer jwboyer at gmail.com
Tue Nov 29 12:12:07 EST 2005


On 11/29/05, Josh Boyer <jwboyer at gmail.com> wrote:
> On 11/29/05, Michael Richardson <mcr at sandelman.ottawa.on.ca> wrote:
> >
> > >>>>> "Wolfgang" == Wolfgang Denk <wd at denx.de> writes:
> >     Wolfgang> In message <v0mzjofaup.fsf at marajade.sandelman.ca> you wrote:
> >     >> This adds an option to ignore CVS directories.
> >
> >     Wolfgang> This doesn't make sense to me. You can and should use "cvs
> >     Wolfgang> export" to create the directory trees you want to package.
> >
> >   yes, one could do that. I chose not to.
> >   It isn't like I forced this option to be on.
> >
> >   cvs export requires that I actually check my changes in before I can test
> > them, which causes a lot of needless churn.
> >   It may also mean that developers in my team will check in debug statements
> > and forget to remove them.
> >
> >     Wolfgang> You use CVS, others use GIT, or Subversion, or ClearCase, or
> >     Wolfgang> Monotone, or darcs, or ... - it would not be really practical
> >     Wolfgang> to add special rules for everybody's favorite tool.
> >
> >   It would very much be practical to do this.
> >   I'd rather have a more general --exclude.
> >
> >   Of course, you argue for removing equivalent options from rsync and other
> > things.  Accept the patch or not.
>
> I believe the answer is "not".

To clarify, the answer is no because you've hard coded this exclude
stuff in the tool itself.  Making a more generic --exclude which reads
what to exclude from a file might be an option that is acceptable. 
Then for your specific case you could simply have "CVS" and ".KEEP_ME"
listed there.

josh




More information about the linux-mtd mailing list