[PATCH] MTD: Add support for the MPC8xxADS boards

[Thomas Gleixner]

On Mon, 2005-11-28 at 21:57 +0300, Vitaly Bordug wrote:
> The following patch adds support for the JEDEC-compatible flashes on
> the MPC8xxADS boards.

Can you please explain how this is supposed to work ?

In any case whether compiled as module or compiled in the init code of
the physmap driver is called before the init code of your board driver.
The physmap_configure() call is just bogus as it overwrites the compiled
in values of the physmap_map structure in physmap.c after the flash was
detected (or not detected) with the compiled in defaults.

Also this code was never compiled and used as a module. 

> Currently verified with MPC885ADS and MPC 866ADS. The patch is against
> MTD git tree.

Currently verified means: it compiles when the config switch is equal
"Y" and the resulting kernel does not oops, right ?


The physmap driver has to be either used with the compiled in address,
size and bankwidth settings or the values have to be set by the early
boot code of the board. Grep through arch/mips to find the two lonely,
but correct, users of physmap_configure().

The same applies for the pq2fads driver. The pq2fads driver is hereby
scheduled for removal.

	tglx