[patch] collie: fixup mtd a bit
Andrew Morton
akpm at osdl.org
Fri Nov 4 18:12:39 EST 2005
Pavel Machek <pavel at ucw.cz> wrote:
>
> Get collie mtd support closer to working/clean state.
>
This patch throws a screen-sized reject due to conflicting changes in
dwmw2's MTD tree. I'd suggest that you rework the patch and send it in via
David (who needs to get a wiggle on if he wants his stuff in 2.6.15).
> default:
> - printk("Waiting for chip\n");
> -
> set_current_state(TASK_INTERRUPTIBLE);
> add_wait_queue(&chip->wq, &wait);
>
> spin_unlock_bh(chip->mutex);
>
> - schedule();
> + udelay(1);
> +
> + set_current_state(TASK_RUNNING);
> remove_wait_queue(&chip->wq, &wait);
>
> if(signal_pending(current))
> @@ -255,7 +256,7 @@ retry:
If you're going to do this then you should remove all that now-pointless
waitqueue and task-state handling.
More information about the linux-mtd
mailing list