[PATCH] accessing NAND flash through an IDE interface

[Thomas Gleixner]

On Fri, 2005-03-11 at 11:23 +0800, William J Beksi wrote:
> > As I said before, I'm not going to accept a change which needs to tweak
> > a source file to make use of it.
> 
> I was not aware of this. I have made all the changes as per your 
> suggestion and then you finally reject the patch, a little discouraging.

I did not intend to discourage you and I'm sorry if I did not express
myself clear enough. I guess my assumptions of what's obvious are wrong.

> Is there any other way let people choose between using readb/inb and 
> writeb/outb inside nand_base.c? 

Sure, more than one.
The simplest is to convert your #define into a CONFIG_OPTION with the
appropriate dependencies.

Another possibility is to make it runtime selectable via the nand
options. Also here it should be compile time dependend on CPU
architectures which have seperate I/O instructions.

> Or should I just create my own separate 
> patch to allow people to use the driver and make it available elsewhere?

Running away is not a solution. Stick your nose into LKML and watch how
patches are dissected several times before acceptance. Whats wrong with
that ? It's the way Open Source development works. 

tglx