Re; MTD (2) Block Driver broken

[Jörn Engel]

On Sat, 5 March 2005 17:26:09 +0000, Gareth Bult wrote:
> 
> A little while back I re-wrote blkmtd.c effectively to provide proper
> "write" access to jffs2 filesystems mounted on standard Linux block
> devices.
> 
> The driver seems to have worked well (for me) and after many thousands
> of downloads of FlashLinux, I've not had any reports of JFFS2 problems
> or corruption.
> 
> It appears that someone has "cleaned up" this driver and it now appears
> as an option in the standard kernel tree for 2.6.11.
> 
> Unfortunately it doesn't appear to work. As soon as you mount a JFFS2
> filesystem on it and try to write data, corruption sets in resulting is
> a fairly sharp system crash.
> 
> Copying back the source from the original driver I submitted to this
> list and recompiling the kernel (with a one line change) appears to
> yield a working system again.
> 
> So, two questions;
> a.	Did anyone actually test the code after cleaning it up?
> b.	Were there any life changing improvements that I really
> 	*need* to make to the original code?

Gareth, check your archives.

I sent the whole list of cleanup patches to you, you could have simply
tested them in order and told me which one broke.  Instead you got
pissed at dwmw2 since he didn't accept your broken mails and
explicitly told me various times, you didn't care about the driver.

The fact that you don't remember me, you don't remember being on Cc:
when I sent patches to Andrew Morton and now come running back is more
than a little disturbing to me.  Va snpg, V nz frireyl cvffrq ng lbh!

So can we pretty please both swallow our feelings and work
constructively together?  Or should I merely treat this mail as a bug
report, go fix it, remove every single line of your code from the
driver and remove your name afterwards?  Both are valid options, you
choose.

Jörn

-- 
It does not matter how slowly you go, so long as you do not stop.
-- Confucius