[PATCH]fs/jffs2/wbuf.c: add compatibility support for OOB data block

Jörn Engel joern at wohnheim.fh-wedel.de
Mon Jul 25 05:20:12 EDT 2005


On Mon, 25 July 2005 17:10:22 +0800, zhao forrest wrote:
> +		node = (struct jffs2_unknown_node *)&buf[current_oob + c->fsdata_pos];
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This part of the patch bugs me a little, even though it's not your
fault.  buf should be of type void*, not char* or unsigned char*.
After that conversion, most casts in this function should go away.

Forrest, if you get bored easily, this would be a nice change.

Rest of the patch looks fine, as far as I'm concerned.  Thanks.

Jörn

-- 
When you close your hand, you own nothing. When you open it up, you
own the whole world.
-- Li Mu Bai in Tiger & Dragon




More information about the linux-mtd mailing list