[PATCH]fs/jffs2/wbuf.c: add compatibility support for OOB data block
Artem B. Bityuckiy
dedekind at yandex.ru
Fri Jul 22 08:12:56 EDT 2005
Jörn Engel wrote:
> Sevenfold indentation is not what I call good coding style. Try to
> make this stuff simpler. Use "if (!...) continue" and similar
Agree, although it is how JFFS2 is written. Let's not worsen it, but
instead, make it tidier. Please, if you don't mind, reformat the whole
function, you may split it on shorter sub-functions, etc.
BTW, IMO the Summary patch of Ferenc Havasi is not yet in CVS (even
though it greatly helps with mount time) because he didn't bothered
making it cute. He just took messy JFFS2 code, and made it even messier.
I'd be glad to see Ferenc's patch nice and in CVS.
Artem B. Bityuckiy,
More information about the linux-mtd