JFFS2-on-DataFlash support

Josh Boyer jdub at us.ibm.com
Mon Jan 31 17:39:10 EST 2005


On Mon, 2005-01-31 at 18:47 +0200, Andrew Victor wrote:

(Note, quoting patches is hard to do when they are sent as attachments).

>@@ -435,7 +435,7 @@
>           if we have a switch to next page, we will not have
>           enough remaining space for this. 
>        */
>-       if (pad) {
>+       if (pad && jffs2_cleanmarker_oob(c)) {
>                c->wbuf_len = PAD(c->wbuf_len);

Why did you do this?  Now padding nodes don't get written out on NOR ECC
flashes.

Could you update the Kconfig file as well?  Config.in is 2.4 only and
I'm sure 2.6 people would like to use this.

Also, could you send the patch inline next time?  Makes it easier to
comment on.

thx,
josh






More information about the linux-mtd mailing list