additional error checks for AG-AND erase/write
David A. Marlin
dmarlin at redhat.com
Fri Jan 21 10:04:24 EST 2005
Thomas Gleixner wrote:
> On Thu, 2005-01-20 at 16:35 -0600, David A. Marlin wrote:
:
>>Note: I changed a few literals to defined symbols in 'nand_base.c'.
>>Please let me know if you would prefer this in a separate patch (or not
>>at all).
>
> If it's not too much work it would be nice when you can do this change
> first.
Sure. Would you like it as a patch, or should I just commit it?
>>@@ -1052,6 +1062,30 @@
>> static int nand_read_ecc (struct mtd_info *mtd, loff_t from, size_t len,
>> size_t * retlen, u_char * buf, u_char * oob_buf, struct nand_oobinfo *oobsel)
>> {
>>+ return do_nand_read_ecc(mtd, from, len, retlen, buf, oob_buf, oobsel, 0xff);
>>+}
>
> Can you please change the call in nand_read too, so it calls
> do_nand_read_ecc directly instead of doing the double call ?
Will do.
As I was looking over this, it occurred to me that the new name
(do_nand_read_ecc) will be visible external to 'nand_base.c', but the
function does not begin with 'nand'. Would it be more appropriate to
call it 'nand_do_read_ecc'? Just trying to be consistent.
Thank you,
d.marlin
More information about the linux-mtd
mailing list