Query Regarding the check_node_data

nishanth menon menon.nishanth at gmail.com
Thu Dec 8 19:37:23 EST 2005


> <snip>
> I dont see how this is valid(may be my understanding is faulty here).
> Since we resize len (len <=csize), and request for mtd-point for len,
> the check for (retlen <tn->csize) will be true and unpoint will be
> called(along with the warning)!!
Dont know if this patch is accepable.
--- 2.6_kernel/fs/jffs2/nodelist.c.orig 2005-12-08 18:36:04.000000000 -0600
+++ 2.6_kernel/fs/jffs2/nodelist.c      2005-12-08 18:36:39.000000000 -0600
@@ -436,7 +436,7 @@
         * adding and jffs2_flash_read_end() interface. */
        if (c->mtd->point) {
                err = c->mtd->point(c->mtd, ofs, len, &retlen, &buffer);
-               if (!err && retlen < tn->csize) {
+               if (!err && (retlen != len)) {
                        JFFS2_WARNING("MTD point returned len too
short: %u instead of %u.\n", retlen, tn->csize);
                        c->mtd->unpoint(c->mtd, buffer, ofs, len);
                } else if (err)

Regards,
Nishanth Menon




More information about the linux-mtd mailing list