[patch 4/4] mtd/cfi_cmdset_0020: replace schedule_timeout() with msleep()

janitor at sternwelten.at janitor at sternwelten.at
Thu Sep 23 16:42:05 EDT 2004




Any comments would be appreciated.

Description: Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc at us.ibm.com>

Signed-off-by: Maximilian Attems <janitor at sternwelten.at>
---

 linux-2.6.9-rc2-bk7-max/drivers/mtd/chips/cfi_cmdset_0020.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff -puN drivers/mtd/chips/cfi_cmdset_0020.c~msleep-drivers_mtd_chips_cfi_cmdset_0020 drivers/mtd/chips/cfi_cmdset_0020.c
--- linux-2.6.9-rc2-bk7/drivers/mtd/chips/cfi_cmdset_0020.c~msleep-drivers_mtd_chips_cfi_cmdset_0020	2004-09-21 21:07:48.000000000 +0200
+++ linux-2.6.9-rc2-bk7-max/drivers/mtd/chips/cfi_cmdset_0020.c	2004-09-21 21:07:48.000000000 +0200
@@ -788,7 +788,7 @@ retry:
 	chip->state = FL_ERASING;
 	
 	spin_unlock_bh(chip->mutex);
-	schedule_timeout(HZ);
+	msleep(1000);
 	spin_lock_bh(chip->mutex);
 
 	/* FIXME. Use a timer to check this, and return immediately. */
@@ -1087,7 +1087,7 @@ retry:
 	chip->state = FL_LOCKING;
 	
 	spin_unlock_bh(chip->mutex);
-	schedule_timeout(HZ);
+	msleep(1000);
 	spin_lock_bh(chip->mutex);
 
 	/* FIXME. Use a timer to check this, and return immediately. */
@@ -1236,7 +1236,7 @@ retry:
 	chip->state = FL_UNLOCKING;
 	
 	spin_unlock_bh(chip->mutex);
-	schedule_timeout(HZ);
+	msleep(1000);
 	spin_lock_bh(chip->mutex);
 
 	/* FIXME. Use a timer to check this, and return immediately. */
_




More information about the linux-mtd mailing list