Bug in nand_select_chip?

[llandre]

>On Wed, 2004-03-17 at 16:44 +0100, llandre wrote:
> > The old function, with chip==0, sets the nCE pin low:
>
> > The new function, with chip==0, sets the nCE pin high:
>
> > 1) Why did the code change this way?
>
>To handle multiple chips. More correctly, should should say
>"The new function, with chip == N, sets nCE on chip #N high."
>
>To deselect _all_ chips you use chip == -1.
>
>All callers of nand_select_chip() were changed at the same time
>though... this shouldn't cause a problem.

I fixed the driver as shown in the NAND Flash document:
- nCE pin low when hwcontrol is invoked with NAND_CTL_SETNCE
- nCE pin high when hwcontrol is invoked with NAND_CTL_CLRNCE

and now the driver works with the new MTD code.




Regards,

llandre