mtd/include/mtd mtd-abi.h,1.1,1.2

[David Woodhouse]

On Fri, 2004-06-04 at 09:16 +0100, gleixner at infradead.org wrote:
> Log Message:
> Extend eccpos array to support HW8_512 ecc on 2k chips. Signed-off-by: Thomas Gleixner <tglx at linutronix.de>

Er, you just changed the kernel<->user ABI and broke all existing
userspace tools compiled with the old one.

Which is OK since this hasn't gone to Linus yet.... but as soon as it
goes to Linus these things are set in stone and you have to extend, not
change. 

Do we want a couple of ints in that structure saying how big the arrays
are? While we're at it, it's better to use explicitly sized types to
make 64<->32 bit ioctl conversion easier.

> --- mtd-abi.h	5 May 2004 14:44:57 -0000	1.1
> +++ mtd-abi.h	4 Jun 2004 08:16:06 -0000	1.2
> @@ -86,7 +86,7 @@
>  struct nand_oobinfo {
>  	int	useecc;
>  	int	eccbytes;
> -	int	eccpos[24];
> +	int	eccpos[32];
>  	int	oobfree[8][2];
>  };

-- 
dwmw2