2.4.26 MTD Patch

[Thayne Harbaugh]

On Thu, 2004-07-15 at 12:45 -0400, Brad Goodman wrote:
> The following patch prevents a kernel OOPS when a faulty MTD device
> times-out,
> due to a the cleanup in the error path being done twice.

Thanks for the patch - maintenance is always appreciated.

> =========== PATCH IS AS FOLLOWS ==========
> 
> --- orig/cfi_cmdset_0002.c      Thu Jul 15 12:31:42 2004
> +++ cfi_cmdset_0002.c   Thu Jul 15 12:30:48 2004
> @@ -6,6 +6,8 @@
>   *
>   * 2_by_8 routines added by Simon Munton
>   *
> + * 7/15/2004 - Brad Goodman <bgoodman at acopia.com> Removed duplicate
> cleanup from error path

looks like your email client line-wrapped the patch - oops!

> + *
>   * This code is GPL
>   *
>   * $Id: cfi_cmdset_0002.c,v 1.62 2003/01/24 23:30:13 dwmw2 Exp $
> @@ -549,11 +551,7 @@

Notice that your patch is against version 1.62.  The current CVS version
is 1.102.

>                         }
>                 } else {
>                         printk(KERN_WARNING "Waiting for write to
> complete timed out in do_write_oneword.");        
> -
> -                       chip->state = FL_READY;
> -                       wake_up(&chip->wq);
> -                       cfi_spin_unlock(chip->mutex);
> -                       DISABLE_VPP(map);
> +
>                         ret = -EIO;
>                 }
>         } 

The code has changed considerably and I don't think this chuck applies.
Please check out a recent version of MTD and check for the double
cleanup (although I have done a simple scan for it).

Once again, thanks for your attention.
 
> --------------------------------------------------------
>  
> DISCLAIMER:   The information contained in this e-mail is confidential
> and is intended solely for the review of the named addressee, and in
> conjunction with specific Acopia Networks business.  Any review,
> retransmission, dissemination or other use of, or taking of any action
> in reliance upon, this information by persons or entities other than
> the intended recipient is prohibited. If you are unable to treat this
> information accordingly, or are not the intended recipient, please
> notify us immediately by returning the e-mail to the originator.  

That disclaimer is just sad.  I imagine you are a victim of your
employer's mail system.