[RFC] refactoring MTD cmdset ops, jedec_probe, and cfi_probe

[Eric W. Biederman]

David Woodhouse <dwmw2 at infradead.org> writes:

> On Tue, 2004-07-13 at 01:05 -0600, Eric W. Biederman wrote:
> > That part does not look to bad...
> 
> Would be interesting to know if it works though ... :)
> 
> > Although there has been some error handling from cfi_cmdset_0002.c which
> > disturbs me.  Seeing as I'm good at finding flaky NOR flash parts...
> 
> I assume you mean some error handling _removed_ from cfi_cmdset_0002.c 
> 
> I don't recall doing that myself... can you elaborate?

Right.  Basically when Thayne was working on cfi_cmdset_0002 we got it stable
for the chips we care about.  But the code was so ugly someone rewrote the
code.  There were other priorities at the time so we have not been able to
get back and fix things up.

The primary thing was that the check that the written data is was what
we actually tried to write was removed.

> > That time line is a bit challenging.  My safe guess was about a week to get
> > everything written and tested... 
> 
> Yeah, that seems reasonable. I'll sync to Linus this week anyway, then I
> can do it again in August when I get back and the dust has settled on
> your changes.

Sounds sane.

Eric