[RFC] refactoring MTD cmdset ops, jedec_probe, and cfi_probe

David Woodhouse dwmw2 at infradead.org
Tue Jul 13 02:25:09 EDT 2004


On Mon, 2004-07-12 at 21:13 -0600, Eric W. Biederman wrote:
> I would like to have the probe functions fill in
> not the CmdSet number but a structure full of function pointers.
> And of course the upper layers need to be modified to cope.

> I have both Intel and AMD chips to test against.  CFI and non CFI
> all being used as motherboard BIOS chips.  So I should be able
> to catch the vast majority of problems in testing.  All but the
> delicate chip interleave case, but I should not actually be touching
> that part of the code, and at least I am aware of the issue.

And I just rewrote that part of the code too :)

> Does anyone have any problems with this refactoring?

No, it seems like a good idea. It'll let us drop half of cfi_cmdset_0020
too.

Once I've done some testing on the new interleave / map access code I
was planning to send an update to Linus this week. That _really_ needs
to happen this week, so if you're going to do this then either do it
today, or wait a month. Personally I favour the former -- the whole
thing needs testing now anyway.

Can you get to #mtd on irc.freenode.net?

-- 
dwmw2






More information about the linux-mtd mailing list