New driver
Josh Boyer
jdub at us.ibm.com
Thu Aug 26 16:52:34 EDT 2004
On Thu, 2004-08-26 at 14:54, Ian Molton wrote:
> On Tue, 24 Aug 2004 01:09:27 +0100
> Ian Molton <spyro at f2s.com> wrote:
>
> > Hi.
> >
> > Here is my first run at the TC6393XB NAND/Smartmedia controller driver.
>
> No comments ?
You forgot to iounmap in your tmio_cleanup function.
Also, you could put:
if(len & 0x3)
BUG();
into a macro. Later, if you can ever guarantee that will never be true,
you can just define the macro to be a no-op. Just a coding style thing
though.
josh
More information about the linux-mtd
mailing list