vmalloc for zlib workspace

David Woodhouse dwmw2 at infradead.org
Thu May 22 14:01:59 EDT 2003


On Thu, 2003-05-22 at 16:40, matsunaga wrote:
> In the jffs2_zlib_init() function of fs/jffs2/comr_zlib.c. 
> workspace is aquired by vmalloc.
> But it could be allocated by static variable, like;
> 
> static char dbuf[WORKSPACESIZE];

Hmm. That's a useful idea. Care to benchmark it an show how _much_ it
improves performance in practice? Although I suppose there's no downside
to it so we might as well change it.

> P.S.2
> fs/jffs2/gc.c
> line 139
>      struct jffs2_inode_cache *ic;
> seems not necessary or the name should be changed.

Fixed; thanks.

-- 
dwmw2





More information about the linux-mtd mailing list