[PATCH] makefile bug and some cleanup

Jörn Engel joern at wohnheim.fh-wedel.de
Sun Mar 2 05:57:30 EST 2003


On Sun, 2 March 2003 10:23:59 +0100, Robert Schwebel wrote:
> 
> Here are two patches against current CVS; the first one fixes the
> utils/Makefile, the second one removes some warnings for erase.c. 

First looks trivial. The second feels wrong.

> -				erase.length, erase.start);
> +				(unsigned long)erase.length, (unsigned long)erase.start);

People (including me) are easily lured into fixing the warnings, which
are only symptoms, instead of the real causes. And this looks exactly
like a symptom fix.

Could be right, though, I didn't dig into the code yet. Maybe tonight.

Jörn

-- 
Geld macht nicht glücklich.
Glück macht nicht satt.




More information about the linux-mtd mailing list