jedec_probe.c

[Joshua Wise]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 05 July 2003 10:50 pm, Eric W. Biederman wrote:
> gen_probe_chip is one case where the cfi and the jedec case are
> common.  Warts are there but it is a common case.  And handling
> the various combinations of interleaved chips and various word
> sizes is tricky, and is quite easy for people who don't need that
> logic to get it wrong if it is not handled in common.

Really? I think it would be better to just probe all the unlock addresses in 
order instead of probing interleaves, etc

> > Sweet, so if jedec_probe was rewritten to not have to use
> > jedec_probe_chip, or gen_probe at all for that matter, we would not
> > have to deal with jedec_probe_chip anywhere else?
>
> Well yes, but I don't see the point in going in that direction.

See above..

> Sorry, I'm not.  Submitting patches for review is another good
> way of accomplishing the same thing, and it is more economical
> of other peoples time.  This is a weekend and one of my rare moments
> with free time.  Thayne Harbaugh should be able to do just as good
> a job at answering your questions and he has a little more time
> than me.

Understood, I can appreciate that :) Who is Thayne Harbaugh? *pokes Thayne 
with a sharp object to call their attention to the discussion*

> Seriously all you should need to do is to take the loop in
> jedec_probe_chip where it loops through some unlock address and have
> it explicitly loop through all of the combinations, or at least enough
> of them until a match is found.  Look for the retry label.  It is a
> significant code change but it should be contained to just that one spot.

I'll take a look into that.

> Eric
~joshua

- -- 
Joshua Wise | www.joshuawise.com
GPG Key     | 0xEA80E0B3
Quote       | <lilo> I akilled *@* by mistake
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/B5PJPn9tWOqA4LMRArvXAJ4tUS/NYq0e2t+6y2Oxj4IQ2I80ygCfaf3H
IUJ864JnVXEOtmf9EnaVhD0=
=qBOM
-----END PGP SIGNATURE-----