jedec_probe.c

Joshua Wise joshua at joshuawise.com
Sat Jul 5 22:15:34 EDT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 05 July 2003 10:11 pm, Eric W. Biederman wrote:
> Ok.  My point is that there is no reason to go through each chip in the
> array.  We can just iterate through the unlock_addrs array, which
> holds every unlock address.

Right, that makes sense.

> We can and do have generic probe functions, in the jedec case.

Not even like that - I meant the way gen_probe.c goes through all interlaces, 
all device sizes, etcetera. I meant that 'different'.

> It is a different probe than the cfi one but it is just as valid.
> The challenge is that the query opcode needs a prefix for some chips
> so we need to loop through all of the prefixes (unlock addresses) instead
> of just some magic subset of them.

Right - guessing at what gen_probe really wants and interpreting it like that, 
IMHO, makes extremely little sense.

> It shouldn't be, and the probes are just used at probe time.  The
> rest of the time their modules can even be unloaded if necessary.

Sweet, so if jedec_probe was rewritten to not have to use jedec_probe_chip, or 
gen_probe at all for that matter, we would not have to deal with 
jedec_probe_chip anywhere else?

Also, out of curiousity, are you on IRC? I would appreciate it if you could 
'look over my shoulder' through a screen session as I hack at a new 
jedec_probe, and poke me with a generic sharp object if I do something 
obviously stupid.

> Eric
~joshua

- -- 
Joshua Wise | www.joshuawise.com
GPG Key     | 0xEA80E0B3
Quote       | <lilo> I akilled *@* by mistake
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/B4ZGPn9tWOqA4LMRAhPaAJwP22JpVB6WzOvaUp/Ah13AjsvRagCgi3vb
9kZlolNsMbJGmt7gk+EtI0k=
=j9jm
-----END PGP SIGNATURE-----




More information about the linux-mtd mailing list