mkfs.jffs2.c rework

David Woodhouse dwmw2 at infradead.org
Mon Nov 25 06:49:05 EST 2002


> /* The kernel assumes PAGE_CACHE_SIZE as block size. */
> #if defined(__ia64__)
> # define PAGE_CACHE_SIZE (16384)
> #else
> # define PAGE_CACHE_SIZE (4096)
> #endif

Er, so if you're cross-building your file system on an IA64, it gets a page
size of 16KiB by default? No likee :)

Anyway, page size isn't even always 16KiB on IA64 either, is it? Stick to 
4KiB default -- it's safer. If you know the target system has a larger page 
size, you can specify it on the command line. Same logic as keeping the 
erase size small by default.

How about changing cpu_to_target32() et al. to be cpu_to_je32() to match the 
JFFS2 code?

Also, could we have an option to write cleanmarkers to the beginning of 
each block?

--
dwmw2






More information about the linux-mtd mailing list