Fwd: jffs2 & new linux zlib

[David Woodhouse]

cdavies at altera.com said:
> What, no comments at all? Shall I just check this in then? - it works
> for me.

Sorry, I missed this one, possibly due to it mentioning 2.5, or the 
combination of https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=53659
and iso8859-15 mails. Neither of which are your fault.

The code against which your patch was made never existed in my CVS tree. It 
was fundamentally broken, as you observed. Whoever did the zlib changes in 
2.5 evidently didn't verify that _either_ jffs2 or ppp_deflate were still 
working. Both are now fixed in Linus' tree, and I've also back-ported the 
(fixed) shared zlib code to 2.4, so that I can import the changes into CVS 
without breaking the 2.4 build. Now, we allocate the workspaces once at 
init time, rather than doing it each time we need to compress/decompress 
something.

2.4 zlib backport patch at ftp.kernel.org:/pub/linux/kernel/people/dwmw2
or in BK tree at http://linux-mtd.bkbits.net:8080/zlib-2.4 (note jffs2-2.4 
tree sitting beside it).

That tree differs from the jffs2-2_4-branch only in the zlib changes, which 
will make their way onto the jffs2-2_4-branch when the zlib changes get 
into 2.4.x.

> I'm not sure that this is the best approach., maybe it would be better
> to try and reduce the size of the deflate_workspace & inflate
> workspace in zlib? (This might be a ridiculous idea, I haven't a clue
> how zlib works) Any suggestions?

The inflate workspace is OK - that's only about 40KiB. If we could reduce 
the deflate workspace from its current 400-odd, that would be useful.

--
dwmw2