jedec_probe_chip error?

[Eric W. Biederman]

"Jeremy Jackson" <jerj at coplanar.net> writes:

> in Linux-MTD:
> 
> I'm looking at mtd/drivers/chips/jedec_probe.c:jedec_probe_chip
> line 794 from current CVS.
> 
> for CFI_DEVICETYPE_X8, the unlock1 and unlock2 values
> seem wrong.   They're currently 0x555 and 0x2aa, resp.
> Does it work like this?  

Unless it's changed since I last looked the code auto detects
whether it should use 0x555/0x2aa or 0x5555/0x2aaa.  If one variant
doesn't work it then tries the other.

> All of the small (512KiB -
> 128KiB) devices I've read the datasheets for, require
> 0x5555 and 0x2aaa here.  Are there any devices which
> use the current code's values?

Yes. I believe it is SST that is the odd man out in this
regard. 
 
> Also, I have discovered (see prev. post) at least one device that doesn't
> respond to the aa 55 90 sequence, requiring an alternate
> "old" sequence instead.  Any guidance on the best way to
> implement this generically would be appreciated.

My hunch is to try the very old sequence last, if the newer
sequences do not work.  In the worst case you will have to write
your own probe routine.  But I suspect Jedec probe can stretch a
little more. 

Eric