Why timer interrupt is disabled?
andreev at niisi.msk.ru
Mon May 28 15:07:46 EDT 2001
I had asked this question to linux-kernel at vger.kernel.org and there is
Jens Axboe wrote:
>On Fri, May 25 2001, Alexandr Andreev wrote:
>>In ll_rw_block.c, before calling block device specific request function
>>( i mean do_hd_request, do_ftl_request, ... ) the io_request_lock is
>>locking, and all interrupts are disabling. I know, that request handler
>>routine have to be atomic, but when we read data from a flash device (
>>for example ) we use a timeouts. Where do we have to enable timer
>>interrupts, or should we disable all interrupts?
>Even with dropping io_request_lock, it's not recommended to sleep inside
>the request_fn. WIth plugging, you are basically preventing the other
>plugged queues from being run until you return.
>You could use a timer or similar to call you on a specified timeout
... and nevertheless, this is a bad idea to unlock the io_request_lock
inside the do_ftl_request. What about the SMP? It may happen that one
CPU is reading and other CPU is writing data at the same time. So, the
flash memory can return status value instead of data, for example. Does
the chip->mutex lock provides necessary synchronization?
I look at the other block device drivers code and found, that io_request
handlers do sti() in some cases. If you still don`t want to do it, we
could use a softirq. In the do_fd_request(), the "bottom halves" is used
for example. We could use a "bottom halves" or even a tasklet in our
case. What do you think about this?
More information about the linux-mtd